Fix read_html_live example#426
Merged
Merged
Conversation
I checked the read_html_live example and saw that the css selectors changed and a cookie consent banner was added. This PR is to changed the read_html_live() example, so it can reject cookies and extract organizations with the new page version. Scroll was needed to force the JSON file download. I used |>, but I can change my PR to %>% if required.
Contributor
Author
|
I see some tests fail because of snapshot changes: Let me know if I have to change something. |
Member
|
Thanks for working on this! I simplified the code further since it seems like we can just use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #430
I checked the read_html_live example and saw that the css selectors changed and a cookie consent banner was added.
This PR is to change the read_html_live() example, so it can reject cookies and extract organizations with the new page version. Reload was needed to force the JSON file download with cookie consent settings already configured.